Using the DEFAULT_TASK_BACKEND_ALIAS constant #36
Conversation
| from .backends.base import BaseTaskBackend | ||
|
|
||
| DEFAULT_QUEUE_NAME = "default" | ||
| DEFAULT_TASK_BACKEND_ALIAS = "default" |
There was a problem hiding this comment.
I am really not sure about the location of that constant. The locations where I wanted to put it produced circular imports, though...
There was a problem hiding this comment.
I think this is why I just duplicated it instead. Tests should cover if they're different.
… default task backend.
dennisstritzke
force-pushed
the
reference-default-backend-alias
branch
from
1447f9e to
4a623b0
Compare
| # Can be replaced with `django.conf.global_settings` once vendored. | ||
| return { | ||
| "default": { | ||
| DEFAULT_TASK_BACKEND_ALIAS: { |
There was a problem hiding this comment.
Suggestion: As discussed, we should document that it should be called "default" (as with DATABASES).
There was a problem hiding this comment.
But even if discarding the rest of the PR, we could still reference that variable instead of writing default again, right?
There was a problem hiding this comment.
DEFAULT_TASK_BACKEND_ALIAS isn't really part of the public API, so people shouldn't need to use it.
|
This PR obviously isn't crucial for the projects success and mostly I question of taste. Looking at the alternatives, I would prefer using the constant in the non-test code as implemented by this PR. If you agree, let's merge it. If you don't agree, feel free to close this PR. 🙃 |
2 participants
Using the
DEFAULT_TASK_BACKEND_ALIASconstant when referencing to the default task backend instead of repeating the string.